Correctly set is_int_min_poison #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As is, is_int_min_poison isn't getting set correctly. Set it correctly and add mlir test to ensure this.
gflegar
approved these changes
Mar 21, 2024
|
Ouch. Thanks for the bugfix. |
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
As is, is_int_min_poison isn't getting set correctly; the LLVM constant being passed to the builder is being interpreted as a C++ bool, so it's always true. Set it correctly and add mlir test to ensure this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, is_int_min_poison isn't getting set correctly; the LLVM constant being passed to the builder is being interpreted as a C++ bool, so it's always true. Set it correctly and add mlir test to ensure this.