[AMD] Treat version as string avoid string/bytes comparison #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglx13
approved these changes
Mar 21, 2024
jataylo
added a commit
to jataylo/triton
that referenced
this pull request
Mar 28, 2024
…ang#3428) Resolves an error observed as part of inductor support bring-up for AMD when running unit test's via PyTorch's run_test.py due to the addition of `-bb` flag in pytest which forbids string/bytes comparisons. ``` File "/opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/_inductor/triton_heuristics.py", line 208, in precompile compiled_binary, launcher = self._precompile_config( File "/opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/_inductor/triton_heuristics.py", line 365, in _precompile_config binary = triton.compile(*compile_args, **compile_kwargs) File "/root/triton/python/triton/compiler/compiler.py", line 229, in compile key = f"{triton_key()}-{src.hash()}-{backend.hash()}-{options.hash()}-{str(sorted(get_env_vars().items()))}" File "/root/triton/python/triton/backends/amd/compiler.py", line 231, in hash return f'{version}-{self.target}' BytesWarning: str() on a bytes instance ``` To resolve this I am proposing to read in the version as a string to avoid string to bytes comparisons (cherry picked from commit 2d80562)
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…ang#3428) Resolves an error observed as part of inductor support bring-up for AMD when running unit test's via PyTorch's run_test.py due to the addition of `-bb` flag in pytest which forbids string/bytes comparisons. ``` File "/opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/_inductor/triton_heuristics.py", line 208, in precompile compiled_binary, launcher = self._precompile_config( File "/opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/_inductor/triton_heuristics.py", line 365, in _precompile_config binary = triton.compile(*compile_args, **compile_kwargs) File "/root/triton/python/triton/compiler/compiler.py", line 229, in compile key = f"{triton_key()}-{src.hash()}-{backend.hash()}-{options.hash()}-{str(sorted(get_env_vars().items()))}" File "/root/triton/python/triton/backends/amd/compiler.py", line 231, in hash return f'{version}-{self.target}' BytesWarning: str() on a bytes instance ``` To resolve this I am proposing to read in the version as a string to avoid string to bytes comparisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an error observed as part of inductor support bring-up for AMD when running unit test's via PyTorch's run_test.py due to the addition of
-bbflag in pytest which forbids string/bytes comparisons.To resolve this I am proposing to read in the version as a string to avoid string to bytes comparisons