Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interpreter] Add exp and log to the interpreter. #3432

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

srush
Copy link
Contributor

@srush srush commented Mar 21, 2024

Getting errors with these in the latest version of triton.

Getting errors with these in the latest version of triton.
@srush srush requested a review from ptillet as a code owner March 21, 2024 17:24
@jlebar
Copy link
Collaborator

jlebar commented Mar 21, 2024

Needs tests (see the other interpreter PRs that have been merged).

cc @Jokeren

@Jokeren
Copy link
Contributor

Jokeren commented Mar 21, 2024

Agree.

Maybe merge the test with test_math_divide_op.

Also I think we could have test_math.py out of test_core.py in the future? What do you think @jlebar ?

@jlebar
Copy link
Collaborator

jlebar commented Mar 21, 2024

Also I think we could have test_math.py out of test_core.py in the future? What do you think @jlebar ?

Personally I think splitting up tests into separate files is useful if and only if we can make a simple rule for why something is in file X versus Y. For example, if math were in a separate namespace, or if it were defined in a separate implementation file, then, fine. But if it's all defined in core.py and it's all in namespace triton.language, I think it invites confusion, e.g. why is tl.minimum in test_math but tl.min in test_core?

But I don't feel strongly and as the person doing the actual work I defer to you.

@Jokeren
Copy link
Contributor

Jokeren commented Mar 21, 2024

Oh sorry, I think I missed some previous commits. I thought all libdevice functions are still under tl.math, actually they have been refactored out to triton.language.extra.cuda. Never mind.

@Jokeren
Copy link
Contributor

Jokeren commented Mar 22, 2024

Merge it for now. And I'll clean up math functions in tl.math and tl in another PR

@Jokeren Jokeren enabled auto-merge (squash) March 22, 2024 00:24
@Jokeren Jokeren merged commit 5ac38e7 into triton-lang:main Mar 22, 2024
5 checks passed
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
Getting errors with these in the latest version of triton.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants