[CI] Update Github actions to node.js 20 #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Resolve GH actions warnings due using deprecated versions of checkout, v2 (node.js 12; EOL) and v3 (node.js 16; EOL), by upgrading to checkout v4 (node.js 20). 2. add -f (force) flag to rm cmds bc it always returns 0 on completion even if file/folder is not found. Without the force flag, "file not found" error causes the cmd to return 1 (fail) when the objective was technically met.
|
fkouteib
commented
Mar 24, 2024
ptillet
approved these changes
Mar 24, 2024
fkouteib
added a commit
to fkouteib/triton
that referenced
this pull request
Mar 24, 2024
Follow-up to PR triton-lang#3445. I missed a couple v3 instance updates. node.js 16 (v3) is deprecated. Moving GH actions to node.js 20 (v4).
ThomasRaoux
pushed a commit
that referenced
this pull request
Apr 2, 2024
Follow-up to PR #3445. I missed a couple v3 instance updates. node.js 16 (v3) is deprecated. Moving GH actions to node.js 20 (v4).
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
1. Resolve GH actions warnings due using deprecated versions of checkout, v2 (node.js 12; EOL) and v3 (node.js 16; EOL), by upgrading to checkout v4 (node.js 20). 2. add -f (force) flag to rm cmds bc it always completes successfully (return 0) even if file/folder is not found. Without the force flag, "file not found" error causes the cmd to return 1 (fail) when the objective was technically met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve GH actions warnings due using deprecated versions of checkout, v2 (node.js 12; EOL) and v3 (node.js 16; EOL), by upgrading to checkout v4 (node.js 20).
add -f (force) flag to rm cmds bc it always completes successfully (return 0) even if file/folder is not found. Without the force flag, "file not found" error causes the cmd to return 1 (fail) when the objective was technically met.