[Backend] hoist ttg.local_alloc only if its valid #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasRaoux
reviewed
Mar 25, 2024
Comment on lines
58
to
64
| if (auto allocOp = dyn_cast<ttg::LocalAllocOp>(op)) { | ||
| // We cannot hoist the allocOp if any of its operands | ||
| // is declared in the forOp's body. | ||
| if (llvm::any_of(allocOp->getOperands(), | ||
| [&](Value operand) { | ||
| return operand.getParentBlock() == forOp.getBody(); | ||
| })) |
There was a problem hiding this comment.
actually can we skip any allocation that has an init value? I thought I did that but looks like I missed it.
Basically:
if (!allocOp.getInit())
continue;
There was a problem hiding this comment.
Thanks for the quick review, Thomas! Would it be possible that the init argument of the allocOp comes from the parent scope of the forOp? If that was the case, we might want something like the following?
auto init = allocOp.getInit();
if (!init || init.getParentBlock() != forOp.getBody())
toHoist.push_back(&op);
There was a problem hiding this comment.
it would work but I don't think that's what we want to do. The idea here is to hoist the alloc created by the inner loop pipelining, we shouldn't try to move the other alloc ops.
There was a problem hiding this comment.
I see. Make sense. Updated the PR. Thanks!
We should only hoist triton_gpu.local_alloc created by the inner loop pipelining. This PR fixed issue triton-lang#3431
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
We cannot hoist a triton_gpu.local_alloc op if its init argument is declared in the same scope as local_alloc's containing for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot hoist a triton_gpu.local_alloc op if its init argument is declared in the same scope as local_alloc's containing for loop.