Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle file paths with spaces (#3305) #3450

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

fkouteib
Copy link
Contributor

A call to split() on a file path string results in a truncated path if the latter has spaces in it, then the target binary is not found. It was an unnecessary step.

call to split() on a file path string results in a truncated path if the latter has spaces in it, then the target binary is not found. It was an unnecessary step.
@fkouteib fkouteib requested a review from ptillet as a code owner March 25, 2024 00:44
Copy link
Collaborator

@jlebar jlebar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great.

@jlebar jlebar merged commit eb59314 into triton-lang:main Mar 25, 2024
5 checks passed
@fkouteib fkouteib deleted the bin_path_with_spaces branch March 27, 2024 02:14
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
A call to split() on a file path string results in a truncated path if
the latter has spaces in it, then the target binary is not found. It was
an unnecessary step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants