[FRONTEND] Keep pointer_type name and its __str__ in-sync. #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that `name` cannot get out of sync with `__str__` and `__repr__`, since all of the fields are technically mutable and can be changed at any time. This also comes with a potential performance benefit of computing this f-string only once instead of computing it on each `__str__`/`__repr__` invocation. It would be even better to also to make this class immutable, but it's a separate story.
|
I'm curious, when would the current code cause a problem? |
in terms of correctness it would cause a problem if someone assigns some value to Also, it's generally not a good idea to call any functions inside of constructor since due to virtual dispatch it's very hard to reason about class invariants. |
ThomasRaoux
changed the title
ThomasRaoux
approved these changes
Mar 25, 2024
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…ng#3453) This change ensures that `name` cannot get out of sync with `__str__` and `__repr__`, since all of the fields are technically mutable and can be changed at any time. This also comes with a potential performance benefit of computing this f-string only once instead of computing it on each `__str__`/`__repr__` invocation. It would be even better to also to make this class immutable, but it's a separate story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that
namecannot get out of sync with__str__and__repr__, since all of the fields are technically mutable and can be changed at any time. This also comes with a potential performance benefit of computing this f-string only once instead of computing it on each__str__/__repr__invocation.It would be even better to also to make this class immutable, but it's a separate story.