Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND][NFC] Simplify reduction function. #3460

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ttsugriy
Copy link
Contributor

Using generators makes code a bit more pythonic and more efficient, although efficiency is not a big deal here due to low cardinality.

Using generators makes code a bit more pythonic and more efficient, although efficiency is not a big deal here due to low cardinality.
@ttsugriy ttsugriy requested a review from ptillet as a code owner March 25, 2024 18:33
Copy link
Collaborator

@jlebar jlebar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, efficiency does not matter at all here. But since this is simpler, we can take the patch!

@jlebar jlebar enabled auto-merge (squash) March 25, 2024 18:36
@ThomasRaoux ThomasRaoux changed the title [lang] Simplify reduction function. [FRONTEND][NFC] Simplify reduction function. Mar 25, 2024
@ThomasRaoux ThomasRaoux disabled auto-merge March 25, 2024 18:38
@ThomasRaoux ThomasRaoux enabled auto-merge (squash) March 25, 2024 18:38
@ThomasRaoux ThomasRaoux merged commit 1acc145 into triton-lang:main Mar 25, 2024
5 checks passed
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
Using generators makes code a bit more pythonic and more efficient,
although efficiency is not a big deal here due to low cardinality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants