Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore build-*/ directories #3462

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

antiagainst
Copy link
Collaborator

@antiagainst antiagainst commented Mar 25, 2024

It's common to use different suffixes to the build
directory when directly compilng from C++.

@antiagainst antiagainst requested a review from ptillet as a code owner March 25, 2024 23:56
@jlebar
Copy link
Collaborator

jlebar commented Mar 26, 2024

Note that you can add a local gitignore that is whatever you want. https://stackoverflow.com/questions/1753070/how-do-i-configure-git-to-ignore-some-files-locally

@antiagainst
Copy link
Collaborator Author

Note that you can add a local gitignore that is whatever you want. https://stackoverflow.com/questions/1753070/how-do-i-configure-git-to-ignore-some-files-locally

Nice, that's good to know; thanks for the tips! For this one I think it makes sense to be checked in given that it's sort of common to see build-* directories when directly compiling from C++.

@ThomasRaoux ThomasRaoux merged commit 9fbc267 into triton-lang:main Mar 26, 2024
5 checks passed
@antiagainst antiagainst deleted the gitignore branch March 30, 2024 16:03
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
It's common to use different suffixes to the build
directory when directly compilng from C++.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants