[backend] Use one linker to link all external libraries #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating a separate linker each time to link a device library to avoid the overhead of internal tracking.
jlebar
approved these changes
Mar 28, 2024
python/src/llvm.cc
Outdated
| llvm::SMDiagnostic err; | ||
| std::unique_ptr<llvm::Module> libMod = llvm::parseIRFile(path, err, ctx); | ||
| if (!libMod) { | ||
| llvm::errs() << "Failed to load " << path; |
There was a problem hiding this comment.
You're not changing it in this PR, but I wonder if you want to raise a Python exception in this case and the other error case below?
There was a problem hiding this comment.
Yup! I'm a bit scared about exceptions, but hey this is Python land. :D
ThomasRaoux
approved these changes
Mar 28, 2024
Yeah I won't expect huge speedup either. I was actually more wanting to see if this addresses some suspected linking issues; turns out not. Either way seems good to have; won't be harmful. |
ptillet
pushed a commit
that referenced
this pull request
Apr 1, 2024
This avoids creating a separate linker each time to link a device library to avoid the overhead of internal tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating a separate linker each time to link a device library to avoid the overhead of internal tracking.