-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rsqrt as a native triton language function #3511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC what does this lower to in PTX?
https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#floating-point-instructions-rsqrt is probably what people want, but it's "approx".
Yup, |
Should we add a warning to the documentation that this is approximate and 1/sqrt(x) may be more accurate? (Maybe the Triton function should even be called rsqrt_approx?) |
I'm not sure these exist for rsqrt.approx? |
Adding support for rsqrt in Triton. Also adding tests for unary math ops.
Adding support for rsqrt in Triton. Also adding tests for unary math ops.