[Backend] Remove extra call to emitIndices. #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storeDistributedToShared and loadSharedToDistributed both accepted a list of indices and then didn't use them. (Instead, they create the indices themselves, lower in the callstack.) Remove these, which removes a bunch of unneded IR. While we're here, we also fix incorrect use of `static` in Utility.h. GPC: extra-emit-indices
jlebar
requested review from
ThomasRaoux
and removed request for
Superjomn,
ptillet and
goostavz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backend] Remove extra call to emitIndices.
storeDistributedToShared and loadSharedToDistributed both accepted a list of
indices and then didn't use them. (Instead, they create the indices
themselves, lower in the callstack.)
Remove these, which removes a bunch of unneded IR.
While we're here, we also fix incorrect use of
staticin Utility.h.PR chain