Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND][NFC] Frontend cleanup #3541

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[FRONTEND][NFC] Frontend cleanup #3541

merged 1 commit into from
Apr 2, 2024

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Apr 2, 2024

  1. Address some flake8 issues like "don't call a function in argument defaults".
  2. Replace some assert False by TypeError with more informative messages.
  3. Remove unused variables

@Jokeren Jokeren requested a review from ptillet as a code owner April 2, 2024 18:09
@Jokeren Jokeren merged commit 8237f1b into main Apr 2, 2024
5 checks passed
@Jokeren Jokeren deleted the keren/minor-frontend branch April 2, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jokeren @ThomasRaoux