[Backend] Assert if we hit known-broken case with small #mma shapes. #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I strongly dislike having to propagate |
|
I will make the change you're asking for, but note that unlike other assertions, for this one we don't actually know how to avoid hitting it. That is, we're not asserting an invariant that we believe we maintain throughout the compiler. So it's quite possible that real users will hit this assertion. |
GPC: mma-error-check
jlebar
force-pushed
the
dev-jlebar/mma-error-check
branch
from
fba1224 to
7d32f42
Compare
jlebar
changed the title
jlebar
requested review from
ThomasRaoux
and removed request for
Superjomn,
ptillet and
goostavz
jlebar
added a commit
that referenced
this pull request
Apr 3, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549. GPC: dot-pipelining
jlebar
added a commit
that referenced
this pull request
Apr 3, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549. GPC: dot-pipelining
jlebar
added a commit
that referenced
this pull request
Apr 4, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549. GPC: dot-pipelining
jlebar
added a commit
that referenced
this pull request
Apr 4, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549. GPC: dot-pipelining
jlebar
added a commit
that referenced
this pull request
Apr 4, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549. GPC: dot-pipelining
jlebar
added a commit
that referenced
this pull request
Apr 4, 2024
PR #3472 partially rolled back PR #3415 due to internal test failures. This PR rolls forward the change as much as we currently can, allowing *most* but not all relevant loads to be pipelined. There is still a TritonGPU -> LLVM codegen bug in Triton that we have not been able to fix, but now we catch it with asserts, PR #3549.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backend] Assert if we hit known-broken case with small #mma shapes.
PR chain