-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTERPRETER] Use acc's dtype as computation dtype in tl.dot
#3566
Conversation
2840cc7
to
c8388f4
Compare
Thank you! Probably we should add a test, or fix an existing one so it catches this bug? |
Yes, please add a test case |
Done. It seems related test cases were deliberately skipped due to this deficiency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Side note: I found a https://github.com/openai/triton/blob/c9800840489fbe04619ad2d4e0e46b868c589d48/python/triton/runtime/interpreter.py#L73 Both are from commit 47a35b6, not sure why this was not caught by CI. |
It doesn't quite matter. |
|
I found with
TRITON_INTERPRET=1
,tl.dot
almost always gives wrong result for INT8 input, due tonp.matmul
use inputs' dtype as result dtype by default: