[CI] Split out pip install and apt-get install into separate build steps.
#3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @antiagainst |
auto-merge was automatically disabled
April 5, 2024 18:04
Pull request was converted to draft
jlebar
force-pushed
the
cache-pip
branch
3 times, most recently
from
9d7dd10 to
223d44b
Compare
zahimoud
approved these changes
Apr 5, 2024
|
The Docker (apparently) already has Torch and some other pip packages installed, but when I add this new thing, we have to install them all from scratch, which is very slow. Caching might help, but it's not clear to me that it would actually be an improvement over the current state of affairs. Maybe instead we should update the Docker so it includes more of the packages we're installing via pip, i.e. make more of the packages like Torch. |
|
Let me use the approval here for the subset of this PR that just splits |
…d steps. This lets us see how long they take.
jlebar
changed the title
pip install and apt-get install into separate build steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us see how long they take.