Removes sinon and chai, Migration to Jest matchers #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayusharma
changed the title
ayusharma
changed the title
pago
approved these changes
Feb 26, 2019
ayusharma
force-pushed
the
88-Complete-switch-to-Jest-&-Snapshots
branch
from
39b7490 to
7a5d6f9
Compare
|
@ayusharma would you be ok if we merge this after the stream API? We'd then need to also update the new tests added there but I'd rather prefer to avoid a conflict on that PR. |
|
@pago Sure 👍 Better to merge after melody-streams. |
ayusharma
force-pushed
the
88-Complete-switch-to-Jest-&-Snapshots
branch
from
7a5d6f9 to
6b611f2
Compare
|
@ayusharma |
|
@pago Yes. It can be merged to master :) |
|
Did you migrate the tests within the new |
|
@pago Yes. Tests have been migrated to use Jest matchers by @krakenfuss in melody-streams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #88
What changed in this PR:
Note: I am waiting #100 to be merged to update changelog.