Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component type attribute so that renderqueue can choose which com… #112

Merged
merged 4 commits into from
Apr 3, 2019

Conversation

krakenfuss
Copy link
Contributor

…ponent type needs optimisation

PLEASE MAKE SURE YOU READ CONTRIBUTING GUIDELINES and CODE OF CONDUCT.

UNLESS IT IS A VERY SMALL CHANGE, CREATE AN ISSUE FIRST FOR DISCUSSION.
** DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.md under
proper category **

i.e:

## master

### Features

- [#ISSUEID](https://github.com/trivago/melody/issues/000) Added coffee brewing feature

REMOVE THIS AND EDIT THE TEMPLATE BELOW


Reference issue: #110

What changed in this PR:

Write the description and changes here...

@coveralls
Copy link

coveralls commented Mar 29, 2019

Pull Request Test Coverage Report for Build 628

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 89.527%

Files with Coverage Reduction New Missed Lines %
packages/melody-idom/src/core.ts 8 92.0%
Totals Coverage Status
Change from base Build 481: 0.005%
Covered Lines: 2159
Relevant Lines: 2288

💛 - Coveralls

@krakenfuss krakenfuss requested a review from pago March 29, 2019 11:59
@pago pago merged commit 064ea1b into master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants