Feature - throw an error in melody-redux's connect if no store found #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesb3ll
reviewed
Oct 2, 2018
packages/melody-redux/src/index.js
Outdated
| @@ -34,6 +34,9 @@ const findNextStore = comp => { | |||
| return node.store; | |||
| } | |||
| } | |||
| if (process.env.NODE_ENV !== 'production') { | |||
| console.error('Could not find store. Did you forget to provide a store?'); | |||
There was a problem hiding this comment.
Maybe throw an Error instead of console.error for a better dev experience?
|
Awesome! Thanks @btiwaree & @jamesb3ll. Last thing missing: Updating the changelog (we do that manually now for better quality). |
|
Thanks again @btiwaree ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an error message that will be thrown when no store is found within findNextStore function.
Currently, the findNextStore function returns null without an error, this causes js errors like Cannot read property 'subscribe' of null or Cannot read property 'getState' of null; this error will provide better context on why the error is being thrown.
P.S. This PR ensues discussions here: #33