-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional arguments for interactive version of generate_mesh
function
#52
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 21 21
Lines 1840 1840
=======================================
Hits 1818 1818
Misses 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the remaining convo is resolved, this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This gives users the possibility to pass the
verbose
output argument from the interactive tool. Also, a new optional inputsubdivision_maximum
allows a user to override the default amount of quadtree subdivisions in HOHQMesh. In the Fortran code this is the-sLimit
flag. The docs are also updated to briefly explain these optional arguments in the "Advanced" part of the overview, because these flags are likely only used by developers.