Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional arguments for interactive version of generate_mesh function #52

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

andrewwinters5000
Copy link
Member

This gives users the possibility to pass the verbose output argument from the interactive tool. Also, a new optional input subdivision_maximum allows a user to override the default amount of quadtree subdivisions in HOHQMesh. In the Fortran code this is the -sLimit flag. The docs are also updated to briefly explain these optional arguments in the "Advanced" part of the overview, because these flags are likely only used by developers.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (d102808) to head (7a660fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          21       21           
  Lines        1840     1840           
=======================================
  Hits         1818     1818           
  Misses         22       22           
Flag Coverage Δ
unittests 98.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 26, 2024

Coverage Status

coverage: 98.804%. remained the same
when pulling 7a660fb on optional-args
into d102808 on main.

docs/src/interactive_overview.md Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
src/HOHQMesh.jl Outdated Show resolved Hide resolved
src/Mesh/Meshing.jl Outdated Show resolved Hide resolved
src/Mesh/Meshing.jl Outdated Show resolved Hide resolved
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the remaining convo is resolved, this LGTM

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 merged commit e79fbbe into main Apr 30, 2024
10 checks passed
@andrewwinters5000 andrewwinters5000 deleted the optional-args branch April 30, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants