Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registered HOHQMesh_jll #6

Merged
merged 7 commits into from
Jun 16, 2021
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Jun 15, 2021

No description provided.

@sloede sloede requested a review from ranocha June 15, 2021 21:41
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #6 (a8d3a57) into main (111cf47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           30        30           
=========================================
  Hits            30        30           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111cf47...a8d3a57. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 15, 2021

Coverage Status

Changes unknown
when pulling 825c5d8 on msl/use-registered-hohqmesh-jll
into ** on main**.

Project.toml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
@sloede sloede requested a review from ranocha June 16, 2021 04:48
ranocha
ranocha previously approved these changes Jun 16, 2021
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and can be merged once HOHQMesh_jll is registered (and tests pass).

@sloede sloede closed this Jun 16, 2021
@sloede sloede reopened this Jun 16, 2021
@sloede sloede requested a review from ranocha June 16, 2021 07:08
@sloede sloede enabled auto-merge June 16, 2021 07:40
@sloede sloede merged commit 803928d into main Jun 16, 2021
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sloede sloede deleted the msl/use-registered-hohqmesh-jll branch June 16, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants