Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override verbatim reactions file path #12

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Mar 15, 2021

With this PR, the full path to the reactions_verbatim.dat file is set in libkrome.{so,dylib} such that it is not necessary to call install_reactions_verbatim anymore.

@coveralls
Copy link

coveralls commented Mar 15, 2021

Pull Request Test Coverage Report for Build 655556065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.0%) to 100.0%

Totals Coverage Status
Change from base Build 654974520: 10.0%
Covered Lines: 2
Relevant Lines: 2

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 655556065

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.0%) to 100.0%

Totals Coverage Status
Change from base Build 654974520: 10.0%
Covered Lines: 2
Relevant Lines: 2

💛 - Coveralls

@sloede
Copy link
Member Author

sloede commented Mar 16, 2021

@mweislev @Cczernik Please note that in the example files I only removed the part where the directory is changed, since this is not necessary anymore as the verbatim reactions file is now automatically loaded from the correct location. The remaining changes are only because of a dedent.

Copy link

@Cczernik Cczernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work 👍

@sloede sloede merged commit eb5584e into main Mar 16, 2021
@sloede sloede deleted the override-verbatim-reactions-path branch March 16, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants