Implement dynamic vector of vectors data structure #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efaulhaber
commented
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 89.86% 91.26% +1.39%
==========================================
Files 13 15 +2
Lines 306 355 +49
==========================================
+ Hits 275 324 +49
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
commented
Jun 24, 2024
efaulhaber
commented
Jun 24, 2024
10 tasks
LasNikas
reviewed
Jun 25, 2024
LasNikas
reviewed
Jun 25, 2024
svchb
previously approved these changes
Jun 25, 2024
LasNikas
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to
VectorOfVectorsof ArraysOfArray.jl, but dynamic, supportingpush!anddeleteat!.This is needed to make #25 GPU-compatible (and more efficient in general).
Coincidentally, the update buffer was using a similar data structure, so we already have a first use-case for this new data structure.