-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EllipsisNotation where useful #189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 91.59% 91.60% +0.01%
==========================================
Files 31 31
Lines 6993 6966 -27
==========================================
- Hits 6405 6381 -24
+ Misses 588 585 -3
Continue to review full report at Codecov.
|
To make sure that these lines are only executed for # Check steady-state integration residual
if solver.equations isa HyperbolicDiffusionEquations2D ||
solver.equations isa HyperbolicDiffusionEquations3D
if maximum(abs, view(solver.elements.u_t, 1, ..)) <= solver.equations.resid_tol
println()
println("-"^80)
println(" Steady state tolerance of ",solver.equations.resid_tol," reached at time ",time)
println("-"^80)
println()
finalstep = true
end
end |
It is not, but it's what was there before. You could do a single check for the abstract type, though: Trixi.jl/src/equations/equations.jl Line 105 in 5a3aa26
|
Ah okay, I didn't see the abstract type before. |
@sloede Is this as you intended? Edit: Didn't see your approval. |
Resolve #179.