Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade baroclinic instability elixir #981

Merged
merged 17 commits into from
Nov 17, 2021

Conversation

efaulhaber
Copy link
Member

This PR

The last two are entirely unrelated to the baroclinic instability, but I just happened to notice this, and I didn't want to create a new PR for this.

ranocha
ranocha previously approved these changes Nov 16, 2021
@ranocha ranocha enabled auto-merge (squash) November 16, 2021 10:20
@efaulhaber
Copy link
Member Author

There's something wrong. The results after 10 days look a bit different.

@ranocha
Copy link
Member

ranocha commented Nov 16, 2021

Please request my review again when you think everything is fine

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #981 (13777b2) into main (edcbadb) will increase coverage by 5.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   87.80%   93.66%   +5.86%     
==========================================
  Files         287      287              
  Lines       20941    20972      +31     
==========================================
+ Hits        18387    19643    +1256     
+ Misses       2554     1329    -1225     
Flag Coverage Δ
unittests 93.66% <100.00%> (+5.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ples/p4est_2d_dgsem/elixir_euler_blast_wave_amr.jl 100.00% <ø> (ø)
examples/p4est_2d_dgsem/elixir_euler_sedov.jl 92.86% <ø> (ø)
..._source_terms_nonconforming_unstructured_curved.jl 100.00% <ø> (ø)
examples/tree_2d_dgsem/elixir_shallowwater_ec.jl 100.00% <ø> (ø)
...tree_2d_dgsem/elixir_shallowwater_well_balanced.jl 100.00% <ø> (ø)
...amples/unstructured_2d_dgsem/elixir_euler_sedov.jl 92.86% <ø> (ø)
...st_3d_dgsem/elixir_euler_baroclinic_instability.jl 98.97% <100.00%> (+0.28%) ⬆️
examples/p4est_3d_dgsem/elixir_euler_sedov.jl 93.75% <100.00%> (ø)
src/auxiliary/auxiliary.jl 90.70% <0.00%> (+0.70%) ⬆️
src/callbacks_step/amr_dg3d.jl 98.37% <0.00%> (+0.81%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edcbadb...13777b2. Read the comment docs.

@efaulhaber
Copy link
Member Author

Alright, it works now. It was just a sign error.

@ranocha ranocha enabled auto-merge (squash) November 16, 2021 18:30
@ranocha ranocha enabled auto-merge (squash) November 16, 2021 18:30
@efaulhaber
Copy link
Member Author

CI finished over 1 hour ago. I don't think codecov will be reporting anything.

@efaulhaber efaulhaber closed this Nov 16, 2021
auto-merge was automatically disabled November 16, 2021 22:01

Pull request was closed

@efaulhaber efaulhaber reopened this Nov 16, 2021
@ranocha ranocha merged commit 37dc9b6 into trixi-framework:main Nov 17, 2021
@efaulhaber efaulhaber deleted the baroclinic-instability branch November 17, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct RHS by subtracting RHS of a steady state solution
2 participants