-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade baroclinic instability elixir #981
Upgrade baroclinic instability elixir #981
Conversation
The translation of the Fortran implementation used a numerical derivative of the stream function, although the exact analytical derivative is stated in the paper.
…ixi.jl into baroclinic-instability
There's something wrong. The results after 10 days look a bit different. |
Please request my review again when you think everything is fine |
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 87.80% 93.66% +5.86%
==========================================
Files 287 287
Lines 20941 20972 +31
==========================================
+ Hits 18387 19643 +1256
+ Misses 2554 1329 -1225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Alright, it works now. It was just a sign error. |
CI finished over 1 hour ago. I don't think codecov will be reporting anything. |
This PR
Downloads:download
in every elixir that was using the deprecateddownload
function,using Downloads:download
in every elixir that doesn't use this function.The last two are entirely unrelated to the baroclinic instability, but I just happened to notice this, and I didn't want to create a new PR for this.