Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new t8code version 3.0.0 #215

Merged
merged 20 commits into from
Nov 16, 2024
Merged

Move to new t8code version 3.0.0 #215

merged 20 commits into from
Nov 16, 2024

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Nov 11, 2024

  • Move to latest t8code version
  • Use t8code's cmake support
  • Enable new t8code Fortran interface
  • Add t8code Fortran controller example
  • Adapt the docs

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (dd3cce5) to head (2ae6191).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   80.52%   81.75%   +1.23%     
==========================================
  Files          19       21       +2     
  Lines         724      773      +49     
  Branches       50       52       +2     
==========================================
+ Hits          583      632      +49     
  Misses        137      137              
  Partials        4        4              
Flag Coverage Δ
unittests 81.75% <100.00%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benegee
Copy link
Collaborator Author

benegee commented Nov 11, 2024

It's been a while, but we have something to review @sloede !

Note that PackageCompiler build currently fails but will be fixed in course of #207 hereafter.

@benegee benegee requested a review from sloede November 11, 2024 16:50
@benegee
Copy link
Collaborator Author

benegee commented Nov 13, 2024

Another ping @sloede as requested. 😃

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just a few questions. Also, some tests seem to be failing?

CMakeLists.txt Show resolved Hide resolved
LibTrixi.jl/src/api_jl.jl Outdated Show resolved Hide resolved
test/c/CMakeLists.txt Outdated Show resolved Hide resolved
@benegee
Copy link
Collaborator Author

benegee commented Nov 14, 2024

Generally LGTM, just a few questions. Also, some tests seem to be failing?

This is package compiler and will hopefully be fixed in course of #207 hereafter.

@benegee benegee requested a review from sloede November 15, 2024 10:05
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sloede sloede merged commit a32e121 into main Nov 16, 2024
4 of 5 checks passed
@sloede sloede deleted the bg/t8code-v3 branch November 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants