-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to new t8code version 3.0.0 #215
Conversation
benegee
commented
Nov 11, 2024
•
edited
Loading
edited
- Move to latest t8code version
- Use t8code's cmake support
- Enable new t8code Fortran interface
- Add t8code Fortran controller example
- Adapt the docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 80.52% 81.75% +1.23%
==========================================
Files 19 21 +2
Lines 724 773 +49
Branches 50 52 +2
==========================================
+ Hits 583 632 +49
Misses 137 137
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Another ping @sloede as requested. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just a few questions. Also, some tests seem to be failing?
This is package compiler and will hopefully be fixed in course of #207 hereafter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!