Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SphereGeometry parameters #120

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Add missing SphereGeometry parameters #120

merged 2 commits into from
Jan 22, 2022

Conversation

xewl
Copy link
Contributor

@xewl xewl commented Jan 22, 2022

Noticed I couldn't use theta & phi Start/Length, which are parameters on the SphereGeometry.

I couldn't seem to test it properly though. The build process isn't very clear (at least, the usage of it locally isn't, I'm using it as a Vue plugin in another project). If that were more clear to me, I'd love to go over the existing Geos, and also add the other missing definition classes.

Edit: I was able to test it when running vite from within this repo. Added comp.* definitions as a result.

PhiStartLength

@klevron
Copy link
Member

klevron commented Jan 22, 2022

Thanks

@klevron klevron merged commit da6396c into troisjs:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants