This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
commented
Mar 11, 2020
Closed
alastair
commented
Mar 16, 2020
alastair
commented
Mar 16, 2020
alastair
force-pushed
the
feat/annotationsnew
branch
from
March 24, 2020 16:58
9db035b
to
1d4d3c5
Compare
alastair
force-pushed
the
feat/annotationsnew
branch
from
June 8, 2020 10:58
1d4d3c5
to
2724b51
Compare
alastair
force-pushed
the
feat/annotationsnew
branch
from
November 12, 2020 13:32
881a1b8
to
626e5b1
Compare
alastair
force-pushed
the
feat/annotationsnew
branch
from
March 12, 2021 15:35
626e5b1
to
e88b40a
Compare
Closed
This was referenced Mar 12, 2021
alastair
force-pushed
the
feat/annotationsnew
branch
from
March 12, 2021 19:10
e88b40a
to
f340866
Compare
alastair
force-pushed
the
feat/annotationsnew
branch
from
March 15, 2021 10:51
f340866
to
17d4834
Compare
This is ready for review. I've managed to create each type of annotation that we need to store. The client demos at https://github.com/trompamusic/trompace-client/tree/master/demo/annotation do each of these types of annotations
Annotations are also ThingInterfaces, and so can be used in an ItemList, to create the concept of an "Annotation session" |
Nice work! |
ChristiaanScheermeijer
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #38
In the previous attempt at annotations, we found that it was very difficult to develop a schema that could allow us to define types, add semantic annotations, and then automatically render to json-ld.
As a result, we came up with this new solution, which defines a graphql-specific schema, and then we'll create a specific json-ld serialiser which can convert this schema into json-ld output.
With @musicog, we believe that this schema fits all required annotation types within Trompa. I'm in the process of documenting the schema, and we'll add this to official documentation soon.
Some items are still pending and need further discussion. I'll mark these in review.