Fix AEP: Always parse out the subdomain, even if already logged in #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd recommend pushing the version number so that the requirement can be changed in home assistant as well. I can add that if you'd like to this PR. |
tronikos
changed the title
|
Thanks for the fix. I released 0.3.1. Please bump the version on the Home Assistant side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue here: home-assistant/core#110019
Basically, this fixes an assertion bug where the server thinks we're already logged in, and we thus exit, but cls._subdomain isn't set, leading to an assertion error down the line.