Feature: During graceful shutdown, more precise control over the readability and writability events of connections to reduce timeouts #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
===================================================
- Coverage 81.73851% 81.60713% -0.13139%
===================================================
Files 855 855
Lines 33891 33899 +8
===================================================
- Hits 27702 27664 -38
- Misses 6189 6235 +46
|
…ability and writability events of connections to reduce timeouts
yujun411522
force-pushed
the
feature/disable_event_when_stop
branch
from
1863ae6 to
36d14b4
Compare
helloopenworld
approved these changes
Apr 1, 2024
| @@ -213,6 +213,21 @@ void TrpcServer::Stop() { | |||
| } | |||
| } | |||
|
|
|||
| // Disable the readable event for the listening socket to avoid creating new connections | |||
| // Disable the readable event for the connected socket to avoid receiving new requests | |||
| std::vector<ServiceAdapterPtr> stop_listened_adapters; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During graceful shutdown, more precise control over the readability and writability events of connections to reduce timeouts