Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add abstract and factory classes for overload controller module #134

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

weimch
Copy link
Contributor

@weimch weimch commented Jun 13, 2024

No description provided.

@weimch
Copy link
Contributor Author

weimch commented Jun 19, 2024

recheck

@weimch weimch closed this Jun 19, 2024
@weimch weimch reopened this Jun 19, 2024
/// @return bool true: succ; false: failed
virtual bool Init() { return true; }

/// @brief Pre handle the request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intercept request before recv request into queue?

/// @return bool true: succ;false: failed
virtual bool OnRequest(const ServerContextPtr& context) = 0;

/// @brief Post handle of after server handling request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get request from queue before handle request?

Copy link
Contributor

@helloopenworld helloopenworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@helloopenworld helloopenworld merged commit c058695 into trpc-group:main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants