Polaris configuration center parsing error when reading configuration file name #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[issue]Fix the issue where a list is parsed as a map at the upper level during parsing. Directly converting it to a list may throw an exception.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
| @@ -71,7 +71,8 @@ private Config buildConfig(Object config) { | |||
| "Polaris plugin config, wrong value type of element in [polaris.configs], expected: Map"); | |||
| Map<String, Object> configMap = (Map<String, Object>) config; | |||
| String group = (String) configMap.get(POLARIS_GROUP_KEY); | |||
| List<String> names = (List<String>) configMap.get(POLARIS_FILENAMES_KEY); | |||
| List<String> names = ((Map<String, String>) configMap.get(POLARIS_FILENAMES_KEY)).values() | |||
There was a problem hiding this comment.
单测没过，需要修一下。也需要评论一下“I have read the CLA Document and I hereby sign the CLA”，授权代码
There was a problem hiding this comment.
单测看了一下直接就实例化成了arraylist了。就没有类型的问题了， 这里主要还是上层配置文件yaml解析到这个插件的时候 ，读取POLARIS_FILENAMES_KEY 这个值成了hashmap了。我看看能不能找到解析成map的地方在哪里 。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error reading configuration file name using Polaris configuration center