-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pd 951 core jail mount point updates #2395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the UI ref content in JailsScreens.md, reorganizes the Wizard and Advanced Creation expand to include heading to proceed the images and moves the nested expand below the images for the settings. It corrects content to reflect changes and adds clarification. It adds brief lists/explanations of the settings in each section to make it easier to find information, especially the settings to assign the zfs dataset and zfs mountpoints. It also makes minor sentence structure changes.
This commit updates headings under the expands to improve readability.
This commit updates the content in the /jails/_index.md file. Adds links to other articles, adds additional explanations of jails and adds additional expand sections and section headers to improve readability. It corrects the procedure for adding a template jail.
This commit updates the content in the SettingUpJailStorage.md article to improve readability. It adds new section headers and additional explanations about how to navigate to screens and what the user needs to do. It adds iocage commands to add a new directory and mount point in an SSH session. It adds new content for adding pointers to datasets from a plugin/jail directory.
This commit fixes issues with a few sentences to clarify the Custom Properties content.
This commit fixes typos, sentence construction, and other minor fixes.
This commit adds a bit of clarification to further address the question of what dataset and directory to use and how to mount them.
DjP-iX
requested changes
Jan 11, 2024
content/CORE/CORETutorials/JailsPluginsVMs/Jails/SettingUpJailStorage.md
Show resolved
Hide resolved
content/CORE/CORETutorials/JailsPluginsVMs/Jails/SettingUpJailStorage.md
Outdated
Show resolved
Hide resolved
content/CORE/CORETutorials/JailsPluginsVMs/Jails/SettingUpJailStorage.md
Show resolved
Hide resolved
Storage is typically added because the user and group account associated with an application installed inside of a jail needs to access data stored on the TrueNAS system. | ||
Before selecting the *Source*, it is important to ensure that the permissions of the selected directory or dataset grant permission to the user or group account inside the jail. | ||
Before selecting the **Source**, it is important to ensure that the permissions of the selected directory or dataset grants permission to the user or group account inside the jail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay as grant, because the subject is permissions
Suggested change
Before selecting the **Source**, it is important to ensure that the permissions of the selected directory or dataset grants permission to the user or group account inside the jail. | |
Before selecting the **Source**, it is important to ensure that the permissions of the selected directory or dataset grant permission to the user or group account inside the jail. |
DjP-iX
added
the
Technical Writer Review (DP)
A technical writer is reviewing the PR.
label
Jan 11, 2024
…Storage.md Co-authored-by: DjP-iX <133042991+DjP-iX@users.noreply.github.com>
…Storage.md Co-authored-by: DjP-iX <133042991+DjP-iX@users.noreply.github.com>
DjP-iX
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the UI reference JailsScreens.md article with new content about the Advanced Jail Creation individual sections, adds headers and moves the expand sections for the content in the Wizard and Advanced Jail Creation expand sections to improve readability and flow.
It updates content in the /JailsPluginsVMs/Jails/_index.md and SettingUpJailStorage.md articles by adding new section headers and content, fixes the procedure to create a jail template. It adds information to address questions raised in the forum.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.