Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pd 1010 update advanced replication article and index #2501

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

micjohnson777
Copy link
Contributor

This PR moves the content in the UseAdvancedReplicationSCALE.md article to the /AdvancedReplication/_index.md file, deletes the original article and adds an alias in the _index.md file.
It updates the content with a new admonition stating Advanced Replication requires an existing periodic snapshot task and matching naming schema in both tasks or advanced replication fails.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This commit moves the article content in UseAdvancedReplicationSCALE.md and moves it into the /AdvancedReplication/_index.md article, and deletes the UseAdvancedReplicationSCALE.md article.
It updates the _index.md content with an alias to the deleted file, and adds a hint admonition stating advanced replication requires an existing periodic snapshot task and matching naming schema in the snapshot and replication task or it fails.
This commit changes the new hint admonition to important and by adding a title for the content.
@micjohnson777 micjohnson777 requested a review from a team as a code owner February 23, 2024 14:02
@Mrt134 Mrt134 added the Review (TM) A technical writer is reviewing the PR. label Feb 26, 2024
Fix issue with text in line 108 related to a periodic snapshot task not existing.
@Mrt134
Copy link
Collaborator

Mrt134 commented Feb 26, 2024

Bonnie reviewed separately from GitHub

Combine redundant text.
Rework conflicting/confusing statements about Snapshot Tasks to simplify the requirement.
Rework some admonition boxes.
Copy link
Collaborator

@Mrt134 Mrt134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught some redundant text and unclear/conflicting statements. Opened a PR with my proposals to adjust the copy a bit and sent to Mic for review.

@Mrt134 Mrt134 self-requested a review February 27, 2024 17:56
@Mrt134 Mrt134 merged commit b2631fc into master Feb 27, 2024
3 checks passed
@Mrt134 Mrt134 deleted the PD-1010-Update-Advanced-Replication-Article-and-Index branch February 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review (TM) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants