-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pd 1010 update advanced replication article and index #2501
Merged
Mrt134
merged 7 commits into
master
from
PD-1010-Update-Advanced-Replication-Article-and-Index
Feb 27, 2024
Merged
Pd 1010 update advanced replication article and index #2501
Mrt134
merged 7 commits into
master
from
PD-1010-Update-Advanced-Replication-Article-and-Index
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the article content in UseAdvancedReplicationSCALE.md and moves it into the /AdvancedReplication/_index.md article, and deletes the UseAdvancedReplicationSCALE.md article. It updates the _index.md content with an alias to the deleted file, and adds a hint admonition stating advanced replication requires an existing periodic snapshot task and matching naming schema in the snapshot and replication task or it fails.
This commit changes the new hint admonition to important and by adding a title for the content.
Fix issue with text in line 108 related to a periodic snapshot task not existing.
Bonnie reviewed separately from GitHub |
Combine redundant text. Rework conflicting/confusing statements about Snapshot Tasks to simplify the requirement. Rework some admonition boxes.
Mrt134
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught some redundant text and unclear/conflicting statements. Opened a PR with my proposals to adjust the copy a bit and sent to Mic for review.
content/SCALE/SCALETutorials/DataProtection/Replication/AdvancedReplication/_index.md
Show resolved
Hide resolved
PD-1010: PR review
Mrt134
approved these changes
Feb 27, 2024
Mrt134
deleted the
PD-1010-Update-Advanced-Replication-Article-and-Index
branch
February 27, 2024 18:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the content in the UseAdvancedReplicationSCALE.md article to the /AdvancedReplication/_index.md file, deletes the original article and adds an alias in the _index.md file.
It updates the content with a new admonition stating Advanced Replication requires an existing periodic snapshot task and matching naming schema in both tasks or advanced replication fails.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.