-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pd 1037 virtual machine instructions for networking incomplete #2515
Merged
Mrt134
merged 19 commits into
master
from
PD-1037-virtual-machine-instructions-for-networking-incomplete
Mar 11, 2024
Merged
Pd 1037 virtual machine instructions for networking incomplete #2515
Mrt134
merged 19 commits into
master
from
PD-1037-virtual-machine-instructions-for-networking-incomplete
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rework admonition to be introductory content - Rewrite first subsection as a numbered step procedure - Add placeholder comment for second subsection to write a numbered step procedure for the other method to configure VM networking.
Update some of the admonitions.
Mrt134
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great reworks! One item left to look at with a small numbered procedure for setting up VM networking on a secondary NIC, but the rest of the changes look fine.
Mrt134
approved these changes
Mar 11, 2024
…etworking-incomplete
Mrt134
deleted the
PD-1037-virtual-machine-instructions-for-networking-incomplete
branch
March 11, 2024 16:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.