NAS-124058 / 24.04 / Stop doing runtime modifications of files in /usr #12075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
force-pushed
the
fhs-changes
branch
from
b7b0e5d to
0992a13
Compare
|
This is related to truenas/scale-build#494 |
themylogin
reviewed
Sep 12, 2023
anodos325
force-pushed
the
fhs-changes
branch
from
0992a13 to
1a4e09b
Compare
themylogin
reviewed
Sep 12, 2023
themylogin
requested changes
Sep 12, 2023
anodos325
force-pushed
the
fhs-changes
branch
from
756956f to
5537074
Compare
This PR makes several changes in preparation for using separate datasets for relevant portions of the root filesystem heirarchy. * Stop permissions checks on stub SMB configuration * Make static netdata configuration changes at install time rather than runtime. * Move local ca certificates path to /var/local rather than /usr/local in accordance with Linux FHS guidelines. Original path (/usr/local/share/ca-certificates) will be replaced with symlink to /var/local/ca-certificates. This PR adds new script that undoes the readonly parts of the root filesystem (and sets custom ZFS user property indicating that server OS is in "developer" mode).
anodos325
force-pushed
the
fhs-changes
branch
from
9f9dc6d to
794fbc8
Compare
This is currently broken in zectl (have pending PR there to fix it).
|
The zectl flag change depends on Which should be merged tomorrow. |
themylogin
approved these changes
Sep 12, 2023
|
@Qubad786 can you review this one since it's making changes to netdata configuration? This is the better approach to take, but I want to make sure you look at it. |
Qubad786
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes in preparation for using separate datasets for relevant portions of the root filesystem heirarchy.