NAS-133186 / 25.04 / Fix port delegate test #15245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
bmeagherix
approved these changes
Dec 19, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port delegate CI test is failing when setting an FTP port.
The problem is previous tests left FTP configured with
onlyanonymousenabled. This setting requires a valid path for the anonymous directory. Additional factor playing into the failure is that the new api method does parameter checking in a slightly different order.The fix: Return
onlyanonymousto false before commencing the failing test.Passing test here: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/2338/