Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133211 / 25.04 / Fix validate_nameservers() #15257

Merged
merged 2 commits into from
Dec 21, 2024
Merged

NAS-133211 / 25.04 / Fix validate_nameservers() #15257

merged 2 commits into from
Dec 21, 2024

Conversation

yocalebo
Copy link
Contributor

verrors is being overwritten and so the validate_nameservers method isn't being applied. We're supposed to be preventing localhost from being used as a DNS server. Since the verrors object is being overwritten, the validation isn't being applied.

I've fixed the problem of the verrors object being overwritten, and I've also added a test to ensure this doesn't happen again.

@yocalebo yocalebo requested a review from a team December 21, 2024 15:29
@bugclerk bugclerk changed the title Fix validate_nameservers() NAS-133211 / 25.04 / Fix validate_nameservers() Dec 21, 2024
@bugclerk
Copy link
Contributor

@yocalebo yocalebo merged commit 1fb40ff into master Dec 21, 2024
2 checks passed
@yocalebo yocalebo deleted the NAS-133211 branch December 21, 2024 15:53
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants