NAS-124675 / 23.10.0 / Fix make clean (by yocalebo) #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the new CI/CD infrastructure, I've had to forcefully stop running builds. Depending on when the build is interrupted, overlayfs mounts are left behind on the system.
However, when we run
make cleanthis fails because the directories that are trying to be removed are backed by the mounted overlayfs mounts. We can safely ignore these errors and move on becausemake packageswill clean up any left over overlay mounts for each package.Finally, use
os.scandirbecause it's more efficient and removeos.path.existscalls that occur before performing file I/O since that's a theoretical race condition.Original PR: #515
Jira URL: https://ixsystems.atlassian.net/browse/NAS-124675