Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-127301 / 24.10 / add codename to manifest.json #595

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

yocalebo
Copy link
Contributor

Product management has asked us to add the code name on the UI side which needs to come from middleware which needs to come from this change 😄

We already have this mostly automated but this will allow us to parse this value on middleware side.

@yocalebo yocalebo requested a review from a team February 22, 2024 20:21
@bugclerk bugclerk changed the title add codename to manifest.json NAS-127301 / 24.10 / add codename to manifest.json Feb 22, 2024
@bugclerk
Copy link
Contributor

@yocalebo yocalebo merged commit 9f95da6 into master Feb 23, 2024
3 checks passed
@yocalebo yocalebo deleted the NAS-127301 branch February 23, 2024 03:51
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants