Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132132 / 25.04 / Inputs | clear icon is too big #11000

Merged
merged 2 commits into from
Nov 12, 2024
Merged

NAS-132132 / 25.04 / Inputs | clear icon is too big #11000

merged 2 commits into from
Nov 12, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Before:
image

Result:

NAS-132132

@AlexKarpov98 AlexKarpov98 self-assigned this Nov 8, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 8, 2024 10:25
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team November 8, 2024 10:25
@bugclerk bugclerk changed the title NAS-132132: Advanced/Basic input - Advanced input is not reacting to NAS-132132 / 25.04 / Advanced/Basic input - Advanced input is not reacting to Nov 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Nov 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132132

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (8962217) to head (967e997).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11000   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files        1614     1614           
  Lines       56877    56877           
  Branches     5887     5887           
=======================================
  Hits        46593    46593           
  Misses      10284    10284

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 changed the title NAS-132132 / 25.04 / Advanced/Basic input - Advanced input is not reacting to NAS-132132 / 25.04 / Inputs | clear icon is too big Nov 9, 2024
bvasilenko
bvasilenko approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexKarpov98 AlexKarpov98 merged commit 21520fe into master Nov 12, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132132 branch November 12, 2024 10:01
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bvasilenko bvasilenko bvasilenko approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @bvasilenko