Ganache's provider type is not compatible with Web3

[davidmurdoch]

it's a matter of
(payload: JsonRpcRequest<...>, callback?: Callback | undefined)
(the relevant part of the type on Ganache)
vs
(payload: JsonRPCRequest, callback: Callback<JsonRPCResponse>)

Full error:

    test/encoder.test.ts:76:50 - error TS2345: Argument of type 'EthereumProvider_2' is not assignable to parameter of type 'Provider'.
      Types of property 'send' are incompatible.
        Type '{ <Method extends never>(method: Method, params?: NoUnknownArray<Parameters<Overloads<EthereumApi[Method]>>> | undefined): cleanAndMergePromiseGenerics<...>; <Method extends never>(payload: JsonRpcRequest<...>, callback?: Callback | undefined): undefined; <Method extends never>(payloads: JsonRpcRequest<...>[], callb...' is not assignable to type '(payload: JsonRPCRequest, callback: Callback<JsonRPCResponse>) => any'.
          Types of parameters 'params' and 'callback' are incompatible.
            Type 'Callback<JsonRPCResponse>' is not assignable to type 'undefined'.
            ```

[MicaiahReid]

Blocked until this web3 PR is merged. web3/web3.js#4743

[koraykoska]

@MicaiahReid As it is merged already, is there any update?

[davidmurdoch]

@koraykoska You can try the new web3 release candidate that contains their fix now: https://github.com/ChainSafe/web3.js/releases/tag/v1.7.2-rc.0

[koraykoska]

@davidmurdoch I am not using web3.js. It's a dependency of ganache and I only use ganache with ethers.

[davidmurdoch]

Web3 is most certainly not a dependency of Ganache. 😁

Are you suggesting ethers doesn't like the Ganache provider type?

[koraykoska]

Yes, so at least Typescript can’t compile properly.

…

On Fri, 8 Apr 2022 at 00:10, David Murdoch ***@***.***> wrote: Web3 is most certainly not a dependency of Ganache. 😁 Are you suggesting ethers doesn't like the Ganache provider type? — Reply to this email directly, view it on GitHub <#2125 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWUTTIVDO3CTBHJ4G3UEDLVD5TMZANCNFSM5MOBCV4Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davidmurdoch]

What is the error?

[koraykoska]

Pretty much what is described here: https://githubhot.com/repo/trufflesuite/ganache-core/issues/2134 I get exactly the same errors and the last working version is 7.0.0-beta.1

…

On Fri, 8 Apr 2022 at 00:27, David Murdoch ***@***.***> wrote: What is the error? — Reply to this email directly, view it on GitHub <#2125 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWUTTNH66KGQ7BPYQ5SYK3VD5VMHANCNFSM5MOBCV4Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davidmurdoch]

Does adding "skipLibCheck": true temporarily fix it for you?

[MicaiahReid]

I've confirmed that types from Ganache v7.0.2 and above are compatible with web3 v1.7.3.