feat: london #1135

davidmurdoch · 2021-09-07T23:20:10Z

Addition of EIP-1559 transactions.
Added baseFeePerGas to a block
When London is activated, use baseFeePerGas as the block's gasPrice
When London is activated, re-prioritize the txPool based off of the transaction's new effectiveGasPrice
Write tests for miner and txPool reordering
Fix some instamine behavior
- Added a DESIGN-DECISIONS.md to explain the change
Set london as the default hard fork
Fixed bug in how typed transactions are signed (no longer including the tx type)

…/ganache into feat/eip-1559-tx-david-temp

src/chains/ethereum/block/src/runtime-block.ts

src/chains/ethereum/ethereum/src/blockchain.ts

src/chains/ethereum/ethereum/src/api.ts

src/chains/ethereum/ethereum/src/blockchain.ts

MicaiahReid · 2021-09-17T14:17:43Z

src/chains/ethereum/transaction/src/rpc-transaction.ts

-  accessList?: never;
-  maxPriorityFeePerGas?: never;
-  maxFeePerGas?: never;
+export type LegacyRpcTransaction = Readonly<RpcTransaction> & {


Curious about the reasoning for this!

We should never mutate the json data a user gives us (like in provider.send("eth_sendTransaction", transaction)) but in one place in our code we were. Marking the type as Readonly prevents that sort of bug from happening.

src/chains/ethereum/transaction/src/signing.ts

src/chains/ethereum/transaction/src/transaction-factory.ts

src/chains/ethereum/block/src/block.ts

It doesn't just throw with an "invalid remainder" message now :-)

davidmurdoch · 2021-09-09T14:59:26Z

src/chains/ethereum/block/src/block.ts

@@ -64,12 +64,11 @@ export class Block {
    });
  }

-  toJSON(includeFullTransactions = false) {
+  toJSON(includeFullTransactions = false, common: Common) {


Probably fine to leave it as is and fix when we re-organize the transactions classes

src/packages/utils/src/utils/heap.ts

src/chains/ethereum/transaction/src/transaction-receipt.ts

davidmurdoch · 2021-09-17T17:58:19Z

src/chains/ethereum/transaction/src/eip1559-fee-market-transaction.ts

@@ -83,7 +106,7 @@ export class EIP1559FeeMarketTransaction extends RuntimeTransaction {
    this.updateEffectiveGasPrice();
  }

-  public toJSON(): EIP1559FeeMarketTransactionJSON {
+  public toJSON(_common?: Common): EIP1559FeeMarketTransactionJSON {


I think the _common is needed because the super class needs it because LegacyTransaction needs it. The _ makes the linter stop complaining about an unused variable.

davidmurdoch · 2021-09-17T18:02:08Z

src/chains/ethereum/transaction/src/rpc-transaction.ts

-  accessList?: never;
-  maxPriorityFeePerGas?: never;
-  maxFeePerGas?: never;
+export type LegacyRpcTransaction = Readonly<RpcTransaction> & {


We should never mutate the json data a user gives us (like in provider.send("eth_sendTransaction", transaction)) but in one place in our code we were. Marking the type as Readonly prevents that sort of bug from happening.

…/ganache into feat/eip-1559-tx-david-temp

MicaiahReid and others added 28 commits September 7, 2021 18:54

add eip1559 raw and rpc types

1fccc78

add eip 1559 tx type

6239952

add standardized gas price across tx types

48762ec

add london hardfork

496a187

add eip1559 to vm tx type

cd5fedd

add base fee per gas to block

21ec3af

use standardized gas price func

3b9c179

normalize type2 txs to legacy pre-berlin

6fc7af0

dont allow nullable nonce

20cd47f

refine baseFeePerGas formula

d5d7df1

normalize txs to type 1559 when appropriate

f100fc5

eip1559 tests

079275e

export eip1559 txs with @ganache/ethereum-tx

44f7163

remove unused receipt params

333a433

add tests for calculating baseFeePerGas

4215ae9

fix bug with block.toJSON

dd917ed

add effectiveGasPrice and methods to update

abd99ba

order/reorder tx pool based off of effectiveGasPrice

8e1d289

add capacity enum to miner

e4010e1

remove unnecessary data

13a81fa

remove instamine from miner. have calcNextBaseFee to return buff

ee49a30

add back gasPrice to receipt

8ca42e7

test for miner and txPool ordering post london

c80a003

add miner design decisions

84184b4

initialize baseFeePerGas as an estimate on eip1559 tx

9ad02e6

fix test that broke due to typed tx hash fix.

4143a46

remove todo

2a6b1df

add london to TRANSACTION_DATA_NON_ZERO_GAS

9196e8b

davidmurdoch changed the base branch from feat/eip-1559-tx to develop September 7, 2021 23:21

remove to-do and unnecessary conversion of datatype

10aceb4

davidmurdoch added 4 commits September 17, 2021 10:23

remove test

ab01639

update docs

108240f

Merge branch 'feat/eip-1559-tx-david-temp' of github.com:trufflesuite…

1a556f0

…/ganache into feat/eip-1559-tx-david-temp

fix comment typo

f272389

MicaiahReid approved these changes Sep 17, 2021

View reviewed changes

davidmurdoch added 15 commits September 17, 2021 10:43

move miner's refresher off fthe miner class

641c60f

try to fix github actions auth issue

f93d1b6

short circuit in Wuantity.toBuffer

dd52708

use bigint when doing gas math stuff

b80b6fe

fix tx type 1 signing error

dab86c0

always validate signature recovery ID

d75de71

update docs

7c73c80

rename repo-token to token in github actions

2f3ebca

fix typo in github action config

7ec7b01

fix typos

0c61590

fix typos

67a48a5

don't allow unlimited time in test

d2e3a09

use static eth_gasPrice for gas price in test

68f6b53

undo whitespace change

8d583ee

Add error for transaction decode failure.

81bb0fd

It doesn't just throw with an "invalid remainder" message now :-)

davidmurdoch commented Sep 17, 2021

View reviewed changes

davidmurdoch and others added 7 commits September 17, 2021 14:08

Update src/packages/utils/src/utils/heap.ts

34e702f

rename lastMaxBlockBaseFee to maxPossibleBaseFee

98324f0

rename calcMaxNBlocksBaseFee to calcNBlocksMaxBaseFee

b3a22ae

Merge branch 'feat/eip-1559-tx-david-temp' of github.com:trufflesuite…

cb5feba

…/ganache into feat/eip-1559-tx-david-temp

move type def from runtime-block to block

958cc40

update error message in test failure

34d2240

update docs

77b9561

MicaiahReid merged commit ded8b37 into develop Sep 17, 2021

MicaiahReid deleted the feat/eip-1559-tx-david-temp branch September 17, 2021 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: london #1135

feat: london #1135

davidmurdoch commented Sep 7, 2021 •

edited by MicaiahReid

Loading

MicaiahReid Sep 17, 2021

davidmurdoch Sep 17, 2021

davidmurdoch Sep 9, 2021

davidmurdoch Sep 17, 2021

davidmurdoch Sep 17, 2021

feat: london #1135

feat: london #1135

Conversation

davidmurdoch commented Sep 7, 2021 • edited by MicaiahReid Loading

MicaiahReid Sep 17, 2021

Choose a reason for hiding this comment

davidmurdoch Sep 17, 2021

Choose a reason for hiding this comment

davidmurdoch Sep 9, 2021

Choose a reason for hiding this comment

davidmurdoch Sep 17, 2021

Choose a reason for hiding this comment

davidmurdoch Sep 17, 2021

Choose a reason for hiding this comment

davidmurdoch commented Sep 7, 2021 •

edited by MicaiahReid

Loading