This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 8, 2022
jeffsmale90
force-pushed
the
feat-getproof
branch
4 times, most recently
from
June 16, 2022 17:52
cd4f178
to
52cd15d
Compare
I'd like to look into leveraging dependency inversion in order to gain access to the underlying world trie and compute the expected values, rather than comparing with static values: #3303. I've deferred those changes so that we can get this out and resolve the associated issues. |
jeffsmale90
changed the title
Implement
Implement Jun 16, 2022
eth_getProof
eth_getProof
(#3076 and #382)
jeffsmale90
changed the title
Implement
Implement Jun 16, 2022
eth_getProof
(#3076 and #382)eth_getProof
gnidan
reviewed
Jun 16, 2022
gnidan
reviewed
Jun 16, 2022
jeffsmale90
force-pushed
the
feat-getproof
branch
2 times, most recently
from
June 27, 2022 22:57
6bbea83
to
c97dd04
Compare
jeffsmale90
commented
Jun 28, 2022
jeffsmale90
commented
Jun 28, 2022
jeffsmale90
force-pushed
the
feat-getproof
branch
from
June 28, 2022 02:03
ab9ec8f
to
4a5b468
Compare
MicaiahReid
suggested changes
Jun 28, 2022
…h_getProof tests deterministic
…lled for a random unused address
jeffsmale90
force-pushed
the
feat-getproof
branch
from
June 28, 2022 21:09
da3b3f9
to
25583fd
Compare
MicaiahReid
approved these changes
Jun 29, 2022
davidmurdoch
suggested changes
Jul 7, 2022
davidmurdoch
reviewed
Jul 7, 2022
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
davidmurdoch
suggested changes
Jul 18, 2022
jeffsmale90
force-pushed
the
feat-getproof
branch
from
July 19, 2022 09:49
6af5b64
to
52ba164
Compare
jeffsmale90
force-pushed
the
feat-getproof
branch
from
July 20, 2022 04:13
52ba164
to
9f3f886
Compare
davidmurdoch
suggested changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALMOST THERE!
davidmurdoch
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eip-1186 proposes a new
eth_getProof
RPC method, which returns a number of useful values, including hashes and proofs associated with the given address and storage keys.Fixes: #3076 and #382