Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat: add eth_getProof RPC method #3199

Merged
merged 15 commits into from
Jul 22, 2022
Merged

feat: add eth_getProof RPC method #3199

merged 15 commits into from
Jul 22, 2022

Conversation

jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Jun 8, 2022

eip-1186 proposes a new eth_getProof RPC method, which returns a number of useful values, including hashes and proofs associated with the given address and storage keys.

Fixes: #3076 and #382

@jeffsmale90 jeffsmale90 force-pushed the feat-getproof branch 4 times, most recently from cd4f178 to 52cd15d Compare June 16, 2022 17:52
@jeffsmale90
Copy link
Contributor Author

jeffsmale90 commented Jun 16, 2022

I'd like to look into leveraging dependency inversion in order to gain access to the underlying world trie and compute the expected values, rather than comparing with static values: #3303.

I've deferred those changes so that we can get this out and resolve the associated issues.

@jeffsmale90 jeffsmale90 changed the title Implement eth_getProof Implement eth_getProof (#3076 and #382) Jun 16, 2022
@jeffsmale90 jeffsmale90 changed the title Implement eth_getProof (#3076 and #382) Implement eth_getProof Jun 16, 2022
@jeffsmale90 jeffsmale90 changed the title Implement eth_getProof feat: add eth_getProof Jun 16, 2022
@jeffsmale90 jeffsmale90 marked this pull request as ready for review June 16, 2022 18:03
@jeffsmale90 jeffsmale90 marked this pull request as draft June 16, 2022 18:40
@jeffsmale90 jeffsmale90 force-pushed the feat-getproof branch 2 times, most recently from 6bbea83 to c97dd04 Compare June 27, 2022 22:57
@jeffsmale90 jeffsmale90 changed the title feat: add eth_getProof feat: add eth_getProof RPC method Jun 28, 2022
@jeffsmale90 jeffsmale90 marked this pull request as ready for review June 28, 2022 07:50
@jeffsmale90 jeffsmale90 requested a review from gnidan June 28, 2022 07:52
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
src/chains/ethereum/ethereum/src/api-types.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api-types.ts Outdated Show resolved Hide resolved
Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALMOST THERE!

src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
src/chains/ethereum/utils/src/index.ts Outdated Show resolved Hide resolved
src/chains/ethereum/ethereum/src/api.ts Outdated Show resolved Hide resolved
@jeffsmale90 jeffsmale90 merged commit 165db66 into develop Jul 22, 2022
@jeffsmale90 jeffsmale90 deleted the feat-getproof branch July 22, 2022 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

No longer able to access state trie Implement eth_getProof RPC message
4 participants