Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: evm_revert fails in some cases #4136

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Jan 9, 2023

Resolves an issue where evm_revert would fail with error .for is not iterable. This happened when a user would attempt to revert a change that deletes a key that exists in an upstream network.

fixes: #4093

@jeffsmale90 jeffsmale90 changed the title Fix/evm revert failure fix: evm_revert fails in some cases Jan 9, 2023
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit, but I think the actual test changes make sense and look good for me. Just some small nits and I'll be ready to approve.

Co-authored-by: Micaiah Reid <micaiahreid@gmail.com>
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
@jeffsmale90 jeffsmale90 merged commit 7de4695 into develop Jan 9, 2023
@jeffsmale90 jeffsmale90 deleted the fix/evm_revert_failure branch January 9, 2023 20:11
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 9, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Ganache Contributor:

GitPOAP: 2023 Ganache Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evm_revert regression
3 participants