Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Upgrade dependency: web3@1.0.0-beta.48 #1793

Closed
wants to merge 4 commits into from
Closed

Upgrade dependency: web3@1.0.0-beta.48 #1793

wants to merge 4 commits into from

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Mar 5, 2019

  • truffle: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-artifactor: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-contract: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-core: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-debugger: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-decode-utils: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-decoder: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-deployer: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-hdwallet-provider: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-migrate: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-provider: 1.0.0-beta.37 → 1.0.0-beta.48
  • truffle-require: 1.0.0-beta.37 → 1.0.0-beta.48

gnidan added 4 commits March 5, 2019 13:54
@gnidan
Upgrade dependency: web3@1.0.0-beta.48
6eff85d 
* truffle: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-artifactor: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-contract: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-core: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-debugger: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-decode-utils: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-decoder: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-deployer: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-hdwallet-provider: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-migrate: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-provider: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-require: 1.0.0-beta.37 →  1.0.0-beta.48
@gnidan
Upgrade dependency: web3-core-promievent@1.0.0-beta.48
70c30a5 
* truffle-contract: 1.0.0-beta.37 →  1.0.0-beta.48
@gnidan
Upgrade dependency: web3-eth-abi@1.0.0-beta.48
806d410 
* truffle-contract: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-debugger: 1.0.0-beta.37 →  1.0.0-beta.48
@gnidan
Upgrade dependency: web3-utils@1.0.0-beta.48
6ffc2ae 
* truffle-contract: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-external-compile: 1.0.0-beta.37 →  1.0.0-beta.48
* truffle-reporters: 1.0.0-beta.37 →  1.0.0-beta.48
@gnidan gnidan marked this pull request as ready for review March 5, 2019 18:58
@imthatcarlos
Copy link

is this slated for the next release? having an issue with truffle-hdwallet-provider web3/web3.js#2447

@gnidan
Copy link
Contributor Author

gnidan commented Mar 7, 2019

is this slated for the next release? having an issue with truffle-hdwallet-provider web3/web3.js#2447

Not as a blocker for release, but it would be nice to have. I am not sure if the team has bandwidth to get this ready by next week, since there's unknown complexity/risk.

I'll say though... if anyone can get an upgrade PR to pass Travis checks, I would consider that a top priority to review/QA. I just fear the unknowns lurking behind the red ❌ there.

Anyway, @nivida did some initial investigation into the test failures here. I will find his results later today and paste here.

@gnidan
Copy link
Contributor Author

gnidan commented Mar 8, 2019

So nivida identified this line, saying:

I’ve checked quickly the provider.js test and this line is definitely invalid.:)

@imthatcarlos
Copy link

Apparently there's an issue with beta.48 and getPastEvents() so we should wait for the next release, sometime this week according to Nivida

@troggy troggy mentioned this pull request Mar 19, 2019
Closed
@gnidan gnidan closed this Mar 25, 2019
@gnidan
Copy link
Contributor Author

gnidan commented Mar 25, 2019

Closing in favor of newer #1852

@imthatcarlos imthatcarlos mentioned this pull request Mar 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnidan @imthatcarlos