Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Refactor Travis CI #1932

Merged
merged 9 commits into from
Apr 22, 2019
Merged

Refactor Travis CI #1932

merged 9 commits into from
Apr 22, 2019

Conversation

CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Apr 19, 2019

This PR refactors CI tests to only install external dependencies for relevant jobs. Also ensures only relevant tests for each job are ran (i.e. geth tests in truffle-contract now skipped in non-geth jobs).

Specific streamlined dependencies:
docker pull for solc & geth, apt-get for jq & snapd, & snap install vyper.

Saves us ~4-5 min for the build.
Resolves #1336.

Also includes updated yarn.lock left out from #1930 .

@CruzMolina CruzMolina requested a review from gnidan April 19, 2019 23:30
@coveralls
Copy link

coveralls commented Apr 20, 2019

Coverage Status

Coverage decreased (-0.3%) to 69.37% when pulling 88b16c0 on travis-refactor into 8abe024 on develop.

@CruzMolina CruzMolina merged commit c296dcf into develop Apr 22, 2019
@CruzMolina CruzMolina deleted the travis-refactor branch April 22, 2019 17:12
@cgewecke
Copy link
Contributor

cgewecke commented May 1, 2019

@CruzMolina Sorry for looking over your shoulder here but possibly this change should be revisited:

geth tests in truffle-contract now skipped in non-geth jobs

Ideally all the tests should pass ganache and but only a subset of them will pass on geth, hence the geth tag.

This is relevant wrt #1852 (upgrade web3) because it looks like many of the relevant tests are now hidden in an allowed failure on CI? Forgive me if I've misunderstood this.

@CruzMolina
Copy link
Contributor Author

Thanks for checking in on geth integration @cgewecke.

I think it's probably time to move the geth job out of it's allowed failure state.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run separate CI task for all tests with external (apt-get) dependencies
4 participants