Handle status for response #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaycev
reviewed
Jan 30, 2024
zaycev
approved these changes
Jan 30, 2024
src/clients.rs
Outdated
| @@ -7,6 +7,15 @@ use crate::types::{BundleUploadLocation, Repo}; | |||
| pub const TRUNK_API_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30); | |||
| pub const TRUNK_API_TOKEN_HEADER: &str = "x-api-token"; | |||
|
|
|||
| fn handle_upload_bundle_error_logs(status: Option<reqwest::StatusCode>) { | |||
| log::error!("Failed to create bundle upload. Status: {:?}", status); | |||
There was a problem hiding this comment.
We should keep the output concise to a single helpful error message.
zaycev
reviewed
Jan 30, 2024
src/clients.rs
Outdated
| return Err(anyhow::anyhow!(e).context("Failed to create bundle upload")); | ||
| } | ||
| }; | ||
|
|
||
| if resp.status() != reqwest::StatusCode::OK { | ||
| handle_upload_bundle_error_logs(Some(resp.status())); |
There was a problem hiding this comment.
I would consider only appending information to context here and moving error logging into a common error-handling location inside main.rs. Otherwise, it seems like we might be double-logging.
riya-n
commented
Feb 1, 2024
src/main.rs
Outdated
| @@ -68,7 +68,7 @@ const DEFAULT_API_ADDRESS: &str = "https://api.trunk.io/v1/metrics/createBundleU | |||
| // This will give us 8ms, 64ms, 512ms, 4096ms, 32768ms | |||
| const RETRY_BASE_MS: u64 = 8; | |||
| const RETRY_FACTOR: u64 = 1; | |||
| const RETRY_COUNT: usize = 5; | |||
| const RETRY_COUNT: usize = 3; | |||
There was a problem hiding this comment.
I don't see why we need to retry 5 times. When making a request with incorrect token, this takes 40 seconds to complete and log the error. With retry 3 times, it only takes a couple of seconds.
There was a problem hiding this comment.
Why do we want to reduce from 40s to 3s though? That's a point of retrying – give backend time to auto-resolve some transient issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.