modularize github codeowners parsing code #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
changed the title
|
✅ 25 passed ⋅ (learn more) |
dfrankland
commented
Sep 23, 2024
There was a problem hiding this comment.
Pretty much exactly the same code from lib.rs. Moved here to better split up code for each CODEOWNERS provider e.g. GitHub vs GitLab vs Bitbucket
Comment on lines
+7
to
+8
| pub trait OwnersOfPath { | ||
| type Owner; |
There was a problem hiding this comment.
split primary public interface of this crate into traits to allow implementing a similar interface for each CODEOWNERS provider
Comment on lines
-112
to
+11
| pub fn of<P>(&self, path: P) -> Option<&Vec<Owner>> | ||
| fn of<P>(&self, path: P) -> Option<Vec<Self::Owner>> |
There was a problem hiding this comment.
removed this reference in favor of an owned Vec since it makes the interface more flexible to implement for each CODEOWNERS provider
There was a problem hiding this comment.
Moved from inside of tests since this added a lot of noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets us up to create a common interface to each CODEOWNERS provider that we implement