1. improve junit-mock for testing #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
changed the title
|
✅ 76 passed ⋅ (learn more) |
dfrankland
commented
Oct 1, 2024
Comment on lines
+73
to
+82
| impl Default for Options { | ||
| fn default() -> Self { | ||
| Options::try_parse_from([""]).unwrap() | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn options_can_be_defaulted_without_panicing() { | ||
| Options::default(); | ||
| } |
There was a problem hiding this comment.
Removes the need for unwraping anytime we need to create options in tests or elsewhere
Comment on lines
+90
to
+93
|
|
||
| /// Timestamp for all data to be based on, defaults to now | ||
| #[arg(long)] | ||
| pub timestamp: Option<DateTime<FixedOffset>>, |
There was a problem hiding this comment.
This allows creating more deterministic mocks which is great for validation checking
Comment on lines
+192
to
+203
|
|
||
| /// The chance of a system out message being added to the test rerun | ||
| #[arg(long, value_parser = clap::value_parser!(u8).range(0..=100), default_value = "50")] | ||
| pub test_rerun_sys_out_percentage: u8, | ||
|
|
||
| /// Inclusive range of time between test case timestamps | ||
| #[arg(long, num_args = 1..=2, value_names = ["DURATION_RANGE_START", "DURATION_RANGE_END"], default_values = ["30s", "1m"])] | ||
| pub test_rerun_duration_range: Vec<humantime::Duration>, | ||
|
|
||
| /// The chance of a system error message being added to the test rerun | ||
| #[arg(long, value_parser = clap::value_parser!(u8).range(0..=100), default_value = "50")] | ||
| pub test_rerun_sys_err_percentage: u8, |
There was a problem hiding this comment.
Added some extra options since we want to try parsing these later on in tests
Comment on lines
+290
to
+300
| ) -> Result<Vec<PathBuf>> { | ||
| reports.as_ref().iter().enumerate().try_fold( | ||
| Vec::new(), | ||
| |mut acc, (i, report)| -> Result<Vec<PathBuf>> { | ||
| let path = directory.as_ref().join(format!("junit-{}.xml", i)); | ||
| let file = File::create(&path)?; | ||
| report.serialize(file)?; | ||
| acc.push(path); | ||
| Ok(acc) | ||
| }, | ||
| ) |
There was a problem hiding this comment.
makes it easier to iterate over generated files instead of hard-coding paths in tests
gnalh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves junit-mocking for better tests, especially ones concerning validation